Skip to content

Fix #8866: Inline calls inserted by macros #8870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fix #8866: Inline calls inserted by macros #8870

merged 1 commit into from
Sep 11, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki linked an issue May 4, 2020 that may be closed by this pull request
Macros do not expand TASTY macros if in any form of nesting #8866
Closed
@nicolasstucki nicolasstucki changed the title Fix #8866: Inline calla inserted by macros Fix #8866: Inline calls inserted by macros May 4, 2020
@nicolasstucki nicolasstucki self-assigned this May 4, 2020
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 3 times, most recently from 6a757ee to 0db5143 Compare May 8, 2020 08:21
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 2 times, most recently from 073fa0d to f100fb0 Compare May 25, 2020 11:13
@nicolasstucki nicolasstucki mentioned this pull request May 29, 2020
Closed
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 2 times, most recently from c1c2910 to 37882fd Compare June 15, 2020 15:05
@anatoliykmetyuk

This comment has been minimized.

Sign in to view
@nicolasstucki nicolasstucki mentioned this pull request Sep 1, 2020
Closed
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 3 times, most recently from 69ba0fe to 4e96236 Compare September 1, 2020 15:45
@nicolasstucki nicolasstucki linked an issue Sep 1, 2020 that may be closed by this pull request
references to inlined method, created in tasty, are not inlined. #9687
Closed
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 2 times, most recently from d1a0ea5 to 92967a6 Compare September 7, 2020 08:36
@nicolasstucki nicolasstucki force-pushed the fix-#8866 branch 2 times, most recently from b8ea9c2 to 985962b Compare September 10, 2020 14:18
@nicolasstucki nicolasstucki marked this pull request as ready for review September 10, 2020 16:36
@nicolasstucki
Copy link
Contributor Author

I finally got the force to finish this one.

@nicolasstucki nicolasstucki removed their assignment Sep 10, 2020
liufengyun
liufengyun reviewed Sep 11, 2020
View reviewed changes
liufengyun
liufengyun approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit b226ff1 into scala:master Sep 11, 2020
@nicolasstucki nicolasstucki deleted the fix-#8866 branch September 11, 2020 14:53
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

references to inlined method, created in tasty, are not inlined. Macros do not expand TASTY macros if in any form of nesting
4 participants
@nicolasstucki @anatoliykmetyuk @liufengyun @Kordyjan